Remove infinite length quirk

This commit is contained in:
Oleg
2024-05-30 11:42:36 +03:00
parent fe6100696e
commit 4826a9d4ef
2 changed files with 2 additions and 11 deletions

View File

@@ -303,10 +303,6 @@ static void pidff_set_effect_report(struct pidff_device *pidff,
{ {
/* check for device quirks */ /* check for device quirks */
unsigned short direction = effect->direction; unsigned short direction = effect->direction;
unsigned short length = effect->replay.length;
if (pidff->quirks & PIDFF_QUIRK_FIX_0_INFINITE_LENGTH && length == 0)
length = 0xffff;
if ((effect->type == FF_DAMPER || if ((effect->type == FF_DAMPER ||
effect->type == FF_FRICTION || effect->type == FF_FRICTION ||
@@ -319,7 +315,8 @@ static void pidff_set_effect_report(struct pidff_device *pidff,
pidff->block_load[PID_EFFECT_BLOCK_INDEX].value[0]; pidff->block_load[PID_EFFECT_BLOCK_INDEX].value[0];
pidff->set_effect_type->value[0] = pidff->set_effect_type->value[0] =
pidff->create_new_effect_type->value[0]; pidff->create_new_effect_type->value[0];
pidff->set_effect[PID_DURATION].value[0] = length; pidff->set_effect[PID_DURATION].value[0] =
effect->replay.length == 0 ? 0xffff : effect->replay.length;
pidff->set_effect[PID_TRIGGER_BUTTON].value[0] = pidff->set_effect[PID_TRIGGER_BUTTON].value[0] =
effect->trigger.button; effect->trigger.button;
pidff->set_effect[PID_TRIGGER_REPEAT_INT].value[0] = pidff->set_effect[PID_TRIGGER_REPEAT_INT].value[0] =

View File

@@ -4,12 +4,6 @@
/* PIDFF Quirks to solve issues with certain devices */ /* PIDFF Quirks to solve issues with certain devices */
/*
* Substitute 0 length with 0xffff to resolve issues with
* infinite effects coming from windows API
*/
#define PIDFF_QUIRK_FIX_0_INFINITE_LENGTH BIT(0)
/* /*
* Ignore direction for spring/damping/friction/inertia effects * Ignore direction for spring/damping/friction/inertia effects
* and always set 16384 * and always set 16384