From d449f45904e1479fcfc2aa40ed4b8ffa3e927167 Mon Sep 17 00:00:00 2001 From: Oleg Date: Mon, 15 Jul 2024 03:34:10 +0300 Subject: [PATCH] Clarify pidff_clamp function usage --- hid-pidff.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hid-pidff.c b/hid-pidff.c index 5174036..2e7516c 100644 --- a/hid-pidff.c +++ b/hid-pidff.c @@ -401,7 +401,12 @@ static void pidff_set_periodic_report(struct pidff_device *pidff, pidff_set_signed(&pidff->set_periodic[PID_OFFSET], effect->u.periodic.offset); pidff_set(&pidff->set_periodic[PID_PHASE], effect->u.periodic.phase); - pidff->set_periodic[PID_PERIOD].value[0] = pidff_clamp(effect->u.periodic.period, pidff->set_periodic[PID_PERIOD].field); + // Actually we just can use clamp macro here + // include/linux/kernel.h#L59 + // But for the debug purposes we're leaving it as is + pidff->set_periodic[PID_PERIOD].value[0] = + pidff_clamp(effect->u.periodic.period, + pidff->set_periodic[PID_PERIOD].field); hid_hw_request(pidff->hid, pidff->reports[PID_SET_PERIODIC], HID_REQ_SET_REPORT);